Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-1161

Generated Delimiter Set Field Should be Static

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.4
    • Fix Version/s: 1.4.5
    • Component/s: codegen
    • Labels:
      None

      Description

      The attached patch just changes __outputDelimiters to static, as it's always constructed the same way and is immutable. It also fixes a trailing whitespace.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1040 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1040/)
        SQOOP-1161: Generated Delimiter Set Field Should be Static (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=db89861c0ca9646a1719037690bc63fead13f6fa)

        • src/java/org/apache/sqoop/orm/ClassWriter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1040 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1040/ ) SQOOP-1161 : Generated Delimiter Set Field Should be Static (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=db89861c0ca9646a1719037690bc63fead13f6fa ) src/java/org/apache/sqoop/orm/ClassWriter.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #842 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/842/)
        SQOOP-1161: Generated Delimiter Set Field Should be Static (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=db89861c0ca9646a1719037690bc63fead13f6fa)

        • src/java/org/apache/sqoop/orm/ClassWriter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #842 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/842/ ) SQOOP-1161 : Generated Delimiter Set Field Should be Static (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=db89861c0ca9646a1719037690bc63fead13f6fa ) src/java/org/apache/sqoop/orm/ClassWriter.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #845 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/845/)
        SQOOP-1161: Generated Delimiter Set Field Should be Static (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=db89861c0ca9646a1719037690bc63fead13f6fa)

        • src/java/org/apache/sqoop/orm/ClassWriter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #845 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/845/ ) SQOOP-1161 : Generated Delimiter Set Field Should be Static (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=db89861c0ca9646a1719037690bc63fead13f6fa ) src/java/org/apache/sqoop/orm/ClassWriter.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #801 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/801/)
        SQOOP-1161: Generated Delimiter Set Field Should be Static (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=db89861c0ca9646a1719037690bc63fead13f6fa)

        • src/java/org/apache/sqoop/orm/ClassWriter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #801 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/801/ ) SQOOP-1161 : Generated Delimiter Set Field Should be Static (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=db89861c0ca9646a1719037690bc63fead13f6fa ) src/java/org/apache/sqoop/orm/ClassWriter.java
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Thank you for your contribution Nick White!

        Show
        jarcec Jarek Jarcec Cecho added a comment - Thank you for your contribution Nick White !
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit db89861c0ca9646a1719037690bc63fead13f6fa in branch refs/heads/trunk from Jarek Jarcec Cecho
        [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=db89861 ]

        SQOOP-1161: Generated Delimiter Set Field Should be Static

        (Nick White via Jarek Jarcec Cecho)

        Show
        jira-bot ASF subversion and git services added a comment - Commit db89861c0ca9646a1719037690bc63fead13f6fa in branch refs/heads/trunk from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=db89861 ] SQOOP-1161 : Generated Delimiter Set Field Should be Static (Nick White via Jarek Jarcec Cecho)
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        It's simple patch, so I'm giving my +1 here.

        Show
        jarcec Jarek Jarcec Cecho added a comment - It's simple patch, so I'm giving my +1 here.
        Hide
        njw45 Nick White added a comment -

        Good point - I've updated the patch to do that too.

        Show
        njw45 Nick White added a comment - Good point - I've updated the patch to do that too.
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Nick White, do you think that it would make sense to also make the __inputDelimiters static?

        Show
        jarcec Jarek Jarcec Cecho added a comment - Nick White , do you think that it would make sense to also make the __inputDelimiters static?

          People

          • Assignee:
            njw45 Nick White
            Reporter:
            njw45 Nick White
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development