Sqoop
  1. Sqoop
  2. SQOOP-1144

Sqoop2: Add fixVersion to PreCommit branch detection

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.99.2
    • Fix Version/s: 1.99.4
    • Component/s: None
    • Labels:
      None

      Description

      Current PreCommit hook code is detecting branches based on affectedVersion field. I think that it will be useful to also use fixVersion field.

      1. SQOOP-1144.patch
        0.7 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Venkat Ranganathan added a comment -

          Thanks Jarek Jarcec Cecho. Sorry I did not update affectsVersion in SQOOP-1139

          Show
          Venkat Ranganathan added a comment - Thanks Jarek Jarcec Cecho . Sorry I did not update affectsVersion in SQOOP-1139
          Hide
          Jarek Jarcec Cecho added a comment -

          No apologies necessary Venkat Ranganathan. The PreCommit hook should be helping developers not causing them headaches in figuring out how to actually use it

          Show
          Jarek Jarcec Cecho added a comment - No apologies necessary Venkat Ranganathan . The PreCommit hook should be helping developers not causing them headaches in figuring out how to actually use it
          Hide
          Jarek Jarcec Cecho added a comment -

          Changing to Patch available state to test change for this JIRA.

          Show
          Jarek Jarcec Cecho added a comment - Changing to Patch available state to test change for this JIRA.
          Hide
          Jarek Jarcec Cecho added a comment -

          Attaching real patch for the ticket.

          Show
          Jarek Jarcec Cecho added a comment - Attaching real patch for the ticket.
          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12614262/SQOOP-1144.patch against branch sqoop2.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch add/modify test case
          SUCCESS: Patch compiled
          SUCCESS: All tests passed

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/186/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12614262/SQOOP-1144.patch against branch sqoop2. Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch add/modify test case SUCCESS: Patch compiled SUCCESS: All tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/186/console This message is automatically generated.
          Hide
          Hari Shreedharan added a comment -

          +1. The best would be if the commit hook good figure out the correct branch by itself even with no fixVersion or affectsVersion – but then maybe I am asking for too much?

          Show
          Hari Shreedharan added a comment - +1. The best would be if the commit hook good figure out the correct branch by itself even with no fixVersion or affectsVersion – but then maybe I am asking for too much?
          Hide
          ASF subversion and git services added a comment -

          Commit 065ecd6d264a6bfe77d984d6f38f56234fd41efd in branch refs/heads/sqoop2 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=065ecd6 ]

          SQOOP-1144. Sqoop2: Add fixVersion to PreCommit branch detection

          (Jarek Jarcec Cecho via Hari Shreedharan)

          Show
          ASF subversion and git services added a comment - Commit 065ecd6d264a6bfe77d984d6f38f56234fd41efd in branch refs/heads/sqoop2 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=065ecd6 ] SQOOP-1144 . Sqoop2: Add fixVersion to PreCommit branch detection (Jarek Jarcec Cecho via Hari Shreedharan)
          Hide
          Hari Shreedharan added a comment -

          Committed! Thanks Jarcec!

          Show
          Hari Shreedharan added a comment - Committed! Thanks Jarcec!
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop2-hadoop200 #534 (See https://builds.apache.org/job/Sqoop2-hadoop200/534/)
          SQOOP-1144. Sqoop2: Add fixVersion to PreCommit branch detection (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=065ecd6d264a6bfe77d984d6f38f56234fd41efd)

          • dev-support/test-patch.py
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop200 #534 (See https://builds.apache.org/job/Sqoop2-hadoop200/534/ ) SQOOP-1144 . Sqoop2: Add fixVersion to PreCommit branch detection (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=065ecd6d264a6bfe77d984d6f38f56234fd41efd ) dev-support/test-patch.py
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop2-hadoop100 #601 (See https://builds.apache.org/job/Sqoop2-hadoop100/601/)
          SQOOP-1144. Sqoop2: Add fixVersion to PreCommit branch detection (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=065ecd6d264a6bfe77d984d6f38f56234fd41efd)

          • dev-support/test-patch.py
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop2-hadoop100 #601 (See https://builds.apache.org/job/Sqoop2-hadoop100/601/ ) SQOOP-1144 . Sqoop2: Add fixVersion to PreCommit branch detection (hshreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=065ecd6d264a6bfe77d984d6f38f56234fd41efd ) dev-support/test-patch.py

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development