Sqoop
  1. Sqoop
  2. SQOOP-1065

Sqoop2: Remove special lock object in FrameworkManager

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.99.2
    • Fix Version/s: 1.99.3
    • Component/s: None
    • Labels:
      None

      Description

      FrameworkManager is currently using special lock object to ensure that we are not running one job multiple times. I think that using a special object is redundant as we can use any other immutable object like the class itself.

      1. bugSQOOP-1065.patch
        1 kB
        Jarek Jarcec Cecho
      2. bugSQOOP-1065.patch
        1 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Sqoop QA bot added a comment -

          Here are the results of testing the latest attachment
          https://issues.apache.org/jira/secure/attachment/12585888/bugSQOOP-1065.patch against branch SQOOP-1082.

          Overall: +1 all checks pass

          SUCCESS: Clean was successful
          SUCCESS: Patch applied correctly
          SUCCESS: Patch compiled
          SUCCESS: All tests passed

          Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/18/console

          This message is automatically generated.

          Show
          Sqoop QA bot added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12585888/bugSQOOP-1065.patch against branch SQOOP-1082 . Overall: +1 all checks pass SUCCESS: Clean was successful SUCCESS: Patch applied correctly SUCCESS: Patch compiled SUCCESS: All tests passed Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/18/console This message is automatically generated.
          Hide
          ASF subversion and git services added a comment -

          Commit 05bd42e1840aa8d58034ab4eab1c92e1c1e47db1 in branch refs/heads/sqoop2 from [~nrv]
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=05bd42e ]

          SQOOP-1065: Sqoop2: Remove special lock object in FrameworkManager

          (Jarek Jarcec Cecho via Venkat Ranganathan)

          Show
          ASF subversion and git services added a comment - Commit 05bd42e1840aa8d58034ab4eab1c92e1c1e47db1 in branch refs/heads/sqoop2 from [~nrv] [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=05bd42e ] SQOOP-1065 : Sqoop2: Remove special lock object in FrameworkManager (Jarek Jarcec Cecho via Venkat Ranganathan)
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #410 (See https://builds.apache.org/job/Sqoop2-hadoop200/410/)
          SQOOP-1065: Sqoop2: Remove special lock object in FrameworkManager (Revision 05bd42e1840aa8d58034ab4eab1c92e1c1e47db1)

          Result = SUCCESS
          venkat : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05bd42e1840aa8d58034ab4eab1c92e1c1e47db1
          Files :

          • core/src/main/java/org/apache/sqoop/framework/JobManager.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #410 (See https://builds.apache.org/job/Sqoop2-hadoop200/410/ ) SQOOP-1065 : Sqoop2: Remove special lock object in FrameworkManager (Revision 05bd42e1840aa8d58034ab4eab1c92e1c1e47db1) Result = SUCCESS venkat : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05bd42e1840aa8d58034ab4eab1c92e1c1e47db1 Files : core/src/main/java/org/apache/sqoop/framework/JobManager.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #409 (See https://builds.apache.org/job/Sqoop2-hadoop100/409/)
          SQOOP-1065: Sqoop2: Remove special lock object in FrameworkManager (Revision 05bd42e1840aa8d58034ab4eab1c92e1c1e47db1)

          Result = SUCCESS
          venkat : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05bd42e1840aa8d58034ab4eab1c92e1c1e47db1
          Files :

          • core/src/main/java/org/apache/sqoop/framework/JobManager.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #409 (See https://builds.apache.org/job/Sqoop2-hadoop100/409/ ) SQOOP-1065 : Sqoop2: Remove special lock object in FrameworkManager (Revision 05bd42e1840aa8d58034ab4eab1c92e1c1e47db1) Result = SUCCESS venkat : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05bd42e1840aa8d58034ab4eab1c92e1c1e47db1 Files : core/src/main/java/org/apache/sqoop/framework/JobManager.java

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development