[SPARK-9073] spark.ml Models copy() should call setParent when there is a parent

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.0
• Component/s: ML
• Target Version/s: 1.5.0
• Assignee: Kai
• Reporter: Joseph K. Bradley
• Shepherd: Joseph K. Bradley
• Created: 15/Jul/15 18:17
• Updated: 13/Aug/15 16:17
• Resolved: 13/Aug/15 16:17

Description

Examples with this mistake include:

• https://github.com/apache/spark/blob/9716a727fb2d11380794549039e12e53c771e120/mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala#L119
• https://github.com/apache/spark/blob/9716a727fb2d11380794549039e12e53c771e120/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L220

Whomever writes a PR for this JIRA should check all spark.ml Model's copy() methods and set copy's Model.parent when available. Also verify in unit tests (possibly in a standard method checking Models to share code).

Issue Links

• links to: [Github] Pull Request #7447 (Lewuathe)