[SPARK-8934] cast from double/float to timestamp should not go through decimal

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: SQL
• Target Version/s: 1.5.0
• Assignee: Wenchen Fan
• Reporter: Reynold Xin
• Created: 09/Jul/15 01:10
• Updated: 09/Jul/15 07:27
• Resolved: 09/Jul/15 07:27

Description

We shouldn't convert the floating point number to decimal and then immediately converting it into a timestamp.

    case DoubleType =>
      buildCast[Double](_, d => try {
        decimalToTimestamp(Decimal(d))
      } catch {
        case _: NumberFormatException => null
      })
    // TimestampWritable.floatToTimestamp
    case FloatType =>
      buildCast[Float](_, f => try {
        decimalToTimestamp(Decimal(f))
      } catch {
        case _: NumberFormatException => null
      })

Issue Links

• is duplicated by: SPARK-8942 use double not decimal when cast double and float to timestamp