Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-7615

MLLIB Word2Vec wordVectors divided by Euclidean Norm equals to zero

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.3.1
    • 1.6.1, 2.0.0
    • MLlib
    • None

    Description

      In Word2VecModel, wordVecNorms may contains Euclidean Norm equals to zero. This will cause incorrect calculation for cosine distance. when you do cosineVec(ind) / wordVecNorms(ind). Cosine distance should be equal to 0 for norm = 0.

      Attachments

        Activity

          Hi, is any body working on this (and SPARK-7617, SPARK-7618)? I have been using Spark for some time, and would like get started contributing. This looks like a trivial issue (good fo a newbie).

          Shall I provide a pull request for this? Would it make sense a pull request for the three related issues?

          amartgon Angel Martinez Gonzalez added a comment - Hi, is any body working on this (and SPARK-7617 , SPARK-7618 )? I have been using Spark for some time, and would like get started contributing. This looks like a trivial issue (good fo a newbie). Shall I provide a pull request for this? Would it make sense a pull request for the three related issues?
          srowen Sean R. Owen added a comment -

          Yes the submitter is about to open another PR, as I understand it.

          srowen Sean R. Owen added a comment - Yes the submitter is about to open another PR, as I understand it.
          apachespark Apache Spark added a comment -

          User 'ezli' has created a pull request for this issue:
          https://github.com/apache/spark/pull/6245

          apachespark Apache Spark added a comment - User 'ezli' has created a pull request for this issue: https://github.com/apache/spark/pull/6245
          apachespark Apache Spark added a comment -

          User 'srowen' has created a pull request for this issue:
          https://github.com/apache/spark/pull/10696

          apachespark Apache Spark added a comment - User 'srowen' has created a pull request for this issue: https://github.com/apache/spark/pull/10696
          srowen Sean R. Owen added a comment - Resolved by https://github.com/apache/spark/pull/10696

          People

            srowen Sean R. Owen
            ezli Eric Li
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified