[SPARK-5524] Remove messy dependencies to log4j

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: Spark Core
• Assignee: Unassigned Assign to me
• Reporter: Jacek Lewandowski
• Created: 02/Feb/15 09:05
• Updated: 31/Mar/15 11:55
• Resolved: 31/Mar/15 11:55

Description

There are some tickets regarding loosening the dependency on Log4j, however some classes still use the following scheme:

  if (Logger.getLogger(classOf[SomeClass]).getLevel == null) {
    Logger.getLogger(classOf[SomeClass]).setLevel(someLevel)
  }

This doesn't look good and make it difficult to track why some logs are missing when you use Log4j and why they are flooding when you use something else, like logback.

There is a Logging class which checks whether we use Log4j or not. Why not delegate all of such invocations, where the Logging class could handle it properly, maybe considering more logging implementations?