[SPARK-49538] Detect unused message parameters

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0
• Component/s: SQL, Tests
• Labels: pull-request-available
• Assignee: Max Gekk
• Reporter: Max Gekk
• Created: 08/Sep/24 09:56
• Updated: 12/Sep/24 01:29
• Resolved: 10/Sep/24 06:33

Description

The passed error message parameters and places holders in message format can not be matched. From the code maintainability perspective, it would be nice to detect such cases while running tests.

For example, the error message format could look like:

  "CANNOT_UP_CAST_DATATYPE" : {
    "message" : [
      "Cannot up cast <expression> from <sourceType> to <targetType>.",
      "<details>"
    ],
    "sqlState" : "42846"
  },

but the passed message parameters have extra parameter:

          messageParameters = Map(
            "expression" -> "CAST('aaa' AS LONG)",
            "sourceType" -> "STRING",
            "targetType" -> "LONG",
            "op" -> "CAST", // unused parameter
            "details" -> "implicit cast"
          ))

Issue Links

• links to: GitHub Pull Request #48026