[SPARK-4896] Don't redundantly copy executor dependencies in Utils.fetchFile

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.2, 1.2.1, 1.3.0
• Component/s: Spark Core
• Assignee: Ryan Williams
• Reporter: Josh Rosen
• Created: 19/Dec/14 05:56
• Updated: 09/Feb/15 05:57
• Resolved: 19/Dec/14 23:55

Description

This JIRA is spun off from a comment by rdub on SPARK-3967, quoted here:

I've been debugging this issue as well and I think I've found an issue in org.apache.spark.util.Utils that is contributing to / causing the problem:

Files.move on line 390 is called even if targetFile exists and tempFile and targetFile are equal.

The check on line 379 seems to imply the desire to skip a redundant overwrite if the file is already there and has the contents that it should have.

Gating the Files.move call on a further if (!targetFile.exists) fixes the issue for me; attached is a patch of the change.

In practice all of my executors that hit this code path are finding every dependency JAR to already exist and be exactly equal to what they need it to be, meaning they were all needlessly overwriting all of their dependency JARs, and now are all basically no-op-ing in Utils.fetchFile; I've not determined who/what is putting the JARs there, why the issue only crops up in yarn-cluster mode (or --master yarn --deploy-mode cluster), etc., but it seems like either way this patch is probably desirable.

I'm spinning this off into its own JIRA so that we can track the merging of https://github.com/apache/spark/pull/2848 separately (since we have multiple PRs that contribute to fixing the original issue).

Issue Links

• is related to: SPARK-3967 Spark applications fail in yarn-cluster mode when the directories configured in yarn.nodemanager.local-dirs are located on different disks/partitions
• links to: [Github] Pull Request #2848 (ryan-williams)