[SPARK-48744] Log entry should be constructed only once

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0
• Component/s: SQL
• Assignee: Gengliang Wang
• Reporter: Gengliang Wang
• Created: 27/Jun/24 22:35
• Updated: 28/Jun/24 04:13
• Resolved: 28/Jun/24 04:13

Description

In the current implementation:

 

class LogEntry(messageWithContext: => MessageWithContext) {
  def message: String = messageWithContext.message
  def context: java.util.HashMap[String, String] = messageWithContext.context
}

def logInfo(entry: LogEntry): Unit = {
  if (log.isInfoEnabled) {
    withLogContext(entry.context) {
      log.info(entry.message)
    }
  }
}

 

 

The field `messageWithContext` is constructed twice, one from `entry.context` and another one from `entry.message`.

We should improve this.