[SPARK-48035] try_add/try_multiply should not be semantic equal to add/multiply

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0
• Component/s: SQL
• Labels: pull-request-available
• Assignee: Gengliang Wang
• Reporter: Gengliang Wang
• Created: 29/Apr/24 02:54
• Updated: 07/May/24 16:17
• Resolved: 07/May/24 01:02

Description

In the current implementation, the following code will return true

val l1 = Literal(1)
val l2 = Literal(2)
val l3 = Literal(3)
val expr1 = Add(Add(l1, l2), l3)
val expr2 = Add(Add(l2, l1, EvalMode.TRY), l3)
expr1.semanticEquals(expr2) 

The same applies to Multiply.

When creating MultiCommutativeOp for Add/Multiply, we should ensure all the evalMode are consistent.

Issue Links

• links to: GitHub Pull Request #46307
• links to: GitHub Pull Request #46413
• links to: GitHub Pull Request #46414