[SPARK-47455] Fix Resource Handling of `scalaStyleOnCompileConfig` in SparkBuild.scala

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.2, 4.0.0, 3.5.1
• Fix Version/s: 4.0.0, 3.5.2, 3.4.3
• Component/s: Project Infra
• Labels: pull-request-available
• Assignee: Yang Jie
• Reporter: Yang Jie
• Created: 19/Mar/24 03:34
• Updated: 20/Mar/24 07:20
• Resolved: 20/Mar/24 07:20

Description

https://github.com/apache/spark/blob/e01ed0da22f24204fe23143032ff39be7f4b56af/project/SparkBuild.scala#L157-L173

 

val scalaStyleOnCompileConfig: String = {
    val in = "scalastyle-config.xml"
    val out = "scalastyle-on-compile.generated.xml"
    val replacements = Map(
      """customId="println" level="error"""" -> """customId="println" level="warn""""
    )
    var contents = Source.fromFile(in).getLines.mkString("\n")
    for ((k, v) <- replacements) {
      require(contents.contains(k), s"Could not rewrite '$k' in original scalastyle config.")
      contents = contents.replace(k, v)
    }
    new PrintWriter(out) {
      write(contents)
      close()
    }
    out
  } 

`Source.fromFile(in)` opens a `BufferedSource` resource handle, but it does not close it.

Issue Links

• links to: GitHub Pull Request #45582