[SPARK-4704] SparkSubmitDriverBootstrap doesn't flush output

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.2.2, 1.3.1, 1.4.0
• Component/s: Spark Core

Environment

1.2.0-rc1

• Assignee: Sean R. Owen
• Reporter: Stephen Haberman
• Created: 02/Dec/14 21:59
• Updated: 13/Mar/15 17:44
• Resolved: 13/Mar/15 17:44

Description

When running spark-submit with a job that immediately blows up (say due to init errors in the job code), there is no error output from spark-submit on the console.

When I ran spark-class directly, then I do see the error/stack trace on the console.

I believe the issue is in SparkSubmitDriverBootstrapper (I had spark.driver.memory set in spark-defaults.conf) not waiting for the RedirectThreads to flush/complete before exiting.

E.g. here:

https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala#L143

I believe around line 165 or so, stdoutThread.join() and
stderrThread.join() calls are necessary to make sure the other threads
have had a chance to flush process.getInputStream/getErrorStream to
System.out/err before the process exits.

I've been tripped up by this in similar RedirectThread/process code, hence suspecting this is the problem.

Issue Links

• links to: [Github] Pull Request #4788 (srowen)