[SPARK-46644] Fix add in SQLMetric

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 4.0.0
• Component/s: SQL
• Labels: pull-request-available
• Assignee: Davin Tjong
• Reporter: Davin Tjong
• Created: 10/Jan/24 01:51
• Updated: 18/Jan/24 03:04
• Resolved: 18/Jan/24 03:04

Description

A previous refactor mistakenly used `isValid` for add. Since `defaultValidValue` was always `0`, this didn't cause any correctness issues.

What we really want to do for add (and merge) is `if (isZero) _value = 0`.

Issue Links

• links to: GitHub Pull Request #44649