Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-46644

Fix add in SQLMetric

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.5.0
    • 4.0.0
    • SQL

    Description

      A previous refactor mistakenly used `isValid` for add. Since `defaultValidValue` was always `0`, this didn't cause any correctness issues.

      What we really want to do for add (and merge) is `if (isZero) _value = 0`.

      Attachments

        Issue Links

          Activity

            People

              dtjong Davin Tjong
              dtjong Davin Tjong
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: