[SPARK-46184] Reduce stack depth by replace Option.isDefined with Option.isEmpty

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0
• Component/s: Connect, MLlib, Spark Core, SQL
• Labels: pull-request-available
• Assignee: Jiaan Geng
• Reporter: Jiaan Geng
• Created: 30/Nov/23 10:04
• Updated: 01/Dec/23 03:12
• Resolved: 01/Dec/23 01:57

Description

There are a lot of Option.isDefined used with !, this behavior increase the stack length.
The reason is isDefined calls isEmpty.
final def isDefined: Boolean = !isEmpty

We also get the compile waring Replace with . isEmpty

Issue Links

• links to: GitHub Pull Request #44091