[SPARK-46173] Skipping trimAll call in stringToDate functions to avoid needless string copy

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 4.0.0
• Component/s: SQL
• Labels: pull-request-available
• Assignee: Aleksandar Tomic
• Reporter: Aleksandar Tomic
• Created: 29/Nov/23 16:04
• Updated: 07/Dec/23 15:35
• Resolved: 06/Dec/23 15:16

Description

In StringToDate function call we currently first call trimAll to remove any whitespace and isocontrol characters. Trimming results in copying the input string which is not really needed given that we can do all the parsing in place by just skipping the whitespace/isocontrol chars.

Given that we have customers complaining about speed of stringtodate function, especially when input string is long/potentially malformed proposal is to skip trimAll call and do parsing in place.

Issue Links

• links to: GitHub Pull Request #44110