[SPARK-45383] Missing case for RelationTimeTravel in CheckAnalysis

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 4.0.0, 3.5.1
• Component/s: Spark Core
• Labels: pull-request-available
• Assignee: Wenchen Fan
• Reporter: Ryan Johnson
• Created: 29/Sep/23 19:40
• Updated: 09/Oct/23 19:16
• Resolved: 09/Oct/23 19:16

Description

CheckAnalysis.checkAnalysis0 lacks a case for RelationTimeTravel, and since the latter is (intentionally) an UnresolvedLeafNode rather than a UnaryNode, the existing checks do not traverse it.

Result: Attempting time travel over a non-existing table produces a spark internal error from the default case, rather than the expected AnalysisException:

[info]   Cause: org.apache.spark.SparkException: [INTERNAL_ERROR] Found the unresolved operator: 'RelationTimeTravel 'UnresolvedRelation [not_exists], [], false, 0
[info]   at org.apache.spark.SparkException$.internalError(SparkException.scala:77)
[info]   at org.apache.spark.sql.catalyst.analysis.CheckAnalysis.$anonfun$checkAnalysis0$54(CheckAnalysis.scala:753) 

Fix should be simple enough:

case tt: RelationTimeTravel =>
  checkAnalysis0(tt.table) 

Issue Links

• links to: GitHub Pull Request #43298