[SPARK-44855] Small tweaks to attaching ExecuteGrpcResponseSender to ExecuteResponseObserver

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.0
• Component/s: Connect
• Labels: pull-request-available
• Epic Link: connect-query-lifecycle
• Assignee: Juliusz Sompolski
• Reporter: Juliusz Sompolski
• Created: 17/Aug/23 17:24
• Updated: 11/Oct/23 19:02
• Resolved: 11/Oct/23 19:02

Description

Small improvements can be made to the way new ExecuteGrpcResponseSender is attached to observer.

• Since now we have addGrpcResponseSender in ExecuteHolder, it should be ExecuteHolder responsibility to interrupt the old sender and that there is only one at a time, and to ExecuteResponseObserver's responsibility
• executeObserver is used as a lock for synchronization. An explicit lock object could be better.

Issue Links

• links to: GitHub Pull Request #43181