[SPARK-4159] Maven build doesn't run JUnit test suites

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: Build
• Assignee: Sean R. Owen
• Reporter: Patrick Wendell
• Created: 30/Oct/14 22:38
• Updated: 30/Apr/15 12:56
• Resolved: 30/Apr/15 12:56

Description

It turns out our Maven build isn't running any Java test suites, and likely hasn't ever.

After some fishing I believe the following is the issue. We use scalatest [1] in our maven build which, by default can't automatically detect JUnit tests. Scalatest will allow you to enumerate a list of suites via "JUnitClasses", but I cant' find a way for it to auto-detect all JUnit tests. It turns out this works in SBT because of our use of the junit-interface[2] which does this for you.

An okay fix for this might be to simply enable the normal (surefire) maven tests in addition to our scalatest in the maven build. The only thing to watch out for is that they don't overlap in some way. We'd also have to copy over environment variables, memory settings, etc to that plugin.

[1] http://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin
[2] https://github.com/sbt/junit-interface

Issue Links

• is related to: SPARK-4814 Enable assertions in SBT, Maven tests / AssertionError from Hive's LazyBinaryInteger
• links to: [Github] Pull Request #3651 (srowen)
• links to: [Github] Pull Request #3993 (srowen)