[SPARK-38735] Test the error class: INTERNAL_ERROR

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.5.0
• Component/s: SQL
• Labels: starter
• Assignee: Eugene Gusev
• Reporter: Max Gekk
• Shepherd: Max Gekk
• Created: 31/Mar/22 18:00
• Updated: 09/Mar/23 19:35
• Resolved: 09/Mar/23 19:35

Description

Add tests for the error class INTERNAL_ERROR to QueryExecutionErrorsSuite. The test should cover the exception throw in QueryExecutionErrors:

  def logicalHintOperatorNotRemovedDuringAnalysisError(): Throwable = {
    new SparkIllegalStateException(errorClass = "INTERNAL_ERROR",
      messageParameters = Array(
        "Internal error: logical hint operator should have been removed during analysis"))
  }

  def cannotEvaluateExpressionError(expression: Expression): Throwable = {
    new SparkUnsupportedOperationException(errorClass = "INTERNAL_ERROR",
      messageParameters = Array(s"Cannot evaluate expression: $expression"))
  }

  def cannotGenerateCodeForExpressionError(expression: Expression): Throwable = {
    new SparkUnsupportedOperationException(errorClass = "INTERNAL_ERROR",
      messageParameters = Array(s"Cannot generate code for expression: $expression"))
  }

  def cannotTerminateGeneratorError(generator: UnresolvedGenerator): Throwable = {
    new SparkUnsupportedOperationException(errorClass = "INTERNAL_ERROR",
      messageParameters = Array(s"Cannot terminate expression: $generator"))
  }
  def methodNotDeclaredError(name: String): Throwable = {
    new SparkNoSuchMethodException(errorClass = "INTERNAL_ERROR",
      messageParameters = Array(
        s"""A method named "$name" is not declared in any enclosing class nor any supertype"""))
  }

For example, here is a test for the error class UNSUPPORTED_FEATURE: https://github.com/apache/spark/blob/34e3029a43d2a8241f70f2343be8285cb7f231b9/sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala#L151-L170

The test must have a check of:

1. the entire error message
2. sqlState if it is defined in the error-classes.json file
3. the error class

Issue Links

• is a clone of: SPARK-38734 Test the error class: INDEX_OUT_OF_BOUNDS
• is cloned by: SPARK-38736 Test the error classes: INVALID_ARRAY_INDEX*
• links to: [Github] Pull Request #40236 (the8thC)
• links to: [Github] Pull Request #40236 (the8thC)