[SPARK-37800] TreeNode.argString incorrectly formats arguments of type Set[_]

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.2.1, 3.3.0
• Component/s: SQL
• Assignee: Simeon Simeonov
• Reporter: Simeon Simeonov
• Created: 01/Jan/22 23:43
• Updated: 12/Dec/22 18:10
• Resolved: 04/Jan/22 04:39

Description

The implementation of argString uses the following pattern for sets:

 

case set: Set[_] =>
  // Sort elements for deterministic behaviours
  val sortedSeq = set.toSeq.map(formatArg(_, maxFields).sorted)                                                              
  truncatedString(sortedSeq, "{", ", ", "}", maxFields) :: Nil 

Instead of sorting the elements of the set, the implementation sorts the characters of the strings that formatArg returns. 

The fix is simply to move the closing parenthesis to the correct location:

  val sortedSeq = set.toSeq.map(formatArg(_, maxFields)).sorted

 

Issue Links

• links to: [Github] Pull Request #35084 (ssimeonov)
• links to: [Github] Pull Request #35105 (HyukjinKwon)