[SPARK-37448] Multiple optimizations related to CurrentOrigin.withOrigin - ASF JIRA

Attach files

Attach Screenshot

Add vote

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: In Progress
Priority: Major
Resolution: Unresolved
Affects Version/s: 4.0.0
Fix Version/s: None
Component/s: Optimizer
Labels:
- pull-request-available

Description

This PR / Jira proposes multiple optimizations related to CurrentOrigin.withOrigin, including:

Avoid CurrentOrigin.withOrigin calls in tree transformation methods when partial function isn't defined

`CurrentOrigin.withOrigin { block }` performs a ThreadLocal.get() call to retrieve the current value of the `origin` thread local so it can be restored after `block` exits.

TreeNode has transform methods which apply PartialFunctions to every node in the tree. By checking `rule.isDefinedAt` before applying a rule we can skip the `CurrentOrigin.withOrigin` call in cases where we know the partial function isn't defined. This avoids the performance overhead associated with thread-local reads and sets.

Small optimizations to withOrigin itself to save a thread-local write.

See PR for full details.