[SPARK-36888] Sha2 with bit_length 512 not being tested

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Component/s: SQL
• Assignee: Richard Chen
• Reporter: H. Vetinari
• Created: 29/Sep/21 04:38
• Updated: 12/Dec/22 18:10
• Resolved: 30/Sep/21 00:53

Description

Looking at https://github.com/apache/spark/commit/6c6291b3f6ac13b8415b87b2b741a9cd95bc6c3b for https://issues.apache.org/jira/browse/SPARK-36836, it's clear that 512 bits are supported

bitLength match {
[...]
  case 512 =>
    UTF8String.fromString(DigestUtils.sha512Hex(input))

resp.

nullSafeCodeGen(ctx, ev, (eval1, eval2) => {
    [...]
    else if ($eval2 == 512) {
       ${ev.value} =
         UTF8String.fromString($digestUtils.sha512Hex($eval1));

but the test claims it is unsupported:

// unsupported bit length
checkEvaluation(Sha2(Literal.create(null, BinaryType), Literal(1024)), null)
checkEvaluation(Sha2(Literal.create(null, BinaryType), Literal(512)), null)

To avoid a similar fate as SPARK-36836, tests should be added.
 
CC richardc-db
 

Issue Links

• links to: [Github] Pull Request #34145 (richardc-db)
• links to: [Github] Pull Request #34145 (richardc-db)