Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-34943

Upgrade flake8 to 3.8.0 or above in Jenkins

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.2.0
    • 3.3.0
    • PySpark
    • None

    Description

      In flake8 < 3.8.0, F401 error occurs for imports in if statements when TYPE_CHECKING is True. However, TYPE_CHECKING is always False at runtime, so there is no need to treat it as an error in static analysis.

      Since this behavior is fixed In flake8 >= 3.8.0, we should upgrade the flake8 installed in Jenkins to 3.8.0 or above. Otherwise, it occurs F401 error for several lines in pandas-on-PySpark that uses TYPE_CHECKING.

      And also we might update the MINIMUM_FLAKE8 in the lint-python from 3.5.0 to 3.8.0.

      Attachments

        Issue Links

          Activity

            People

              shaneknapp Shane Knapp
              itholic Haejoon Lee
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: