[SPARK-33619] GetMapValueUtil code generation error

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.0
• Fix Version/s: 3.1.0
• Component/s: SQL
• Assignee: Leanken.Lin
• Reporter: Leanken.Lin
• Created: 01/Dec/20 09:23
• Updated: 04/Jan/21 23:20
• Resolved: 02/Dec/20 16:11

Description

```

In SPARK-33460--

there is a bug as follow.

GetMapValueUtil generated code error when ANSI mode is on

 

s"""throw new NoSuchElementException("Key " + $eval2 + " does not exist.");"""

should be 

s"""throw new java.util.NoSuchElementException("Key " + $eval2 + " does not exist.");"""

 

But Why are

checkExceptionInExpression[Exception](expr, errMsg)

and sql/testOnly org.apache.spark.sql.SQLQueryTestSuite – -z ansi/map.sql

can't detect this Bug

 

it's because 

1. checkExceptionInExpression is some what error, too. it should wrap with 

withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key like CheckEvalulation, AND WE SHOULD FIX this later.

2. SQLQueryTestSuite ansi/map.sql failed to detect because of the ConstantFolding rules, it is calling eval instead of code gen  in this case

 

```

Issue Links

• causes: SPARK-33948 ExpressionEncoderSuite failed in spark-branch-3.1-test-maven-hadoop-*-jdk-*-scala-2.13
• links to: [Github] Pull Request #30560 (leanken)