[SPARK-3288] All fields in TaskMetrics should be private and use getters/setters

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.3.0
• Component/s: Spark Core
• Labels: starter
• Target Version/s: 1.3.0
• Assignee: Ilya Ganelin
• Reporter: Patrick Wendell
• Created: 28/Aug/14 20:38
• Updated: 19/Jan/15 09:33
• Resolved: 19/Jan/15 09:32

Description

This is particularly bad because we expose this as a developer API. Technically a library could create a TaskMetrics object and then change the values inside of it and pass it onto someone else. It can be written pretty compactly like below:

  /**
   * Number of bytes written for the shuffle by this task
   */
  @volatile private var _shuffleBytesWritten: Long = _
  def incrementShuffleBytesWritten(value: Long) = _shuffleBytesWritten += value
  def decrementShuffleBytesWritten(value: Long) = _shuffleBytesWritten -= value
  def shuffleBytesWritten = _shuffleBytesWritten

Issue Links

• links to: [Github] Pull Request #4020 (ilganeli)