Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.1.0
    • 3.1.0
    • Spark Core, Tests
    • None

    Description

      This issue aims to fix `SorterSuite` and `RadixSortSuite` in Scala 2.13 by using `sameElements` instead of `IndexSeqView.==`.

      Scala 2.13 reimplements `IndexSeqView` and the behavior is different.

      Welcome to Scala 2.12.10 (OpenJDK 64-Bit Server VM, Java 1.8.0_262).
      Type in expressions for evaluation. Or try :help.
      
      scala> Seq(1,2,3).toArray.view == Seq(1,2,3).toArray.view
      res0: Boolean = true
      
      Welcome to Scala 2.13.3 (OpenJDK 64-Bit Server VM, Java 1.8.0_262).
      Type in expressions for evaluation. Or try :help.
      
      scala> Seq(1,2,3).toArray.view == Seq(1,2,3).toArray.view
      val res0: Boolean = false
      
      $ dev/change-scala-version.sh 2.13
      $ build/mvn test -pl core --am -Pscala-2.13 -Dtest=none -DwildcardSuites=org.apache.spark.util.collection.unsafe.sort.RadixSortSuite
      ...
      Tests: succeeded 9, failed 36, canceled 0, ignored 0, pending 0
      *** 36 TESTS FAILED ***
      
      $ build/mvn test -pl core --am -Pscala-2.13 -Dtest=none -DwildcardSuites=org.apache.spark.util.collection.SorterSuite
      ...
      Tests: succeeded 3, failed 1, canceled 0, ignored 2, pending 0
      *** 1 TEST FAILED ***
      

      Attachments

        Activity

          People

            dongjoon Dongjoon Hyun
            dongjoon Dongjoon Hyun
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: