[SPARK-31416] Check more strictly that a field name can be used as a valid Java identifier for codegen

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: SQL
• Assignee: Kousuke Saruta
• Reporter: Kousuke Saruta
• Created: 10/Apr/20 18:14
• Updated: 02/Feb/21 23:54
• Resolved: 12/Apr/20 20:15

Description

ScalaReflection checks that a field name can be used as a valid Java identifier by checking whether the field name is not a reserved keyword.

But, in the current implementation, enum is missed.
Further, some characters including numeric literals are not used as valid identifiers but not checked.

Issue Links

• is duplicated by: SPARK-29594 Create a Dataset from a Sequence of Case class
• links to: GitHub Pull Request #28184