[SPARK-30009] Replace Ordering.Double with Ordering.Double.TotalOrdering

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Spark Core, SQL
• Assignee: Sean R. Owen
• Reporter: Sean R. Owen
• Created: 24/Nov/19 21:59
• Updated: 04/Sep/20 05:04
• Resolved: 26/Nov/19 16:26

Description

Scala 2.12 replaces Ordering.Double with either of Ordering.Double.TotalOrdering (same behavior, NaN compares consistently) or Ordering.Double.IeeeOrdering (consistent with java.lang.Double.compare, NaN always compares false, for example). Neither is available in both versions, and it doesn't seem like a compat library exists to handle this.

This can be accomplished by inlining the implementation of Ordering.Double so that both can use it. Or, parallel source trees for 2.12 / 2.13. The latter wouldn't be worth it just for this, but I'm fairly sure a few things will require it anyway.

Issue Links

• causes: SPARK-32764 compare of -0.0 < 0.0 return true
• links to: GitHub Pull Request #26654
• links to: GitHub Pull Request #26761