[SPARK-29081] Replace calls to SerializationUtils.clone on properties with a faster implementation.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Spark Core
• Assignee: David Lewis
• Reporter: David Lewis
• Created: 13/Sep/19 22:32
• Updated: 25/Nov/19 19:34
• Resolved: 15/Sep/19 07:30

Description

I don't have empirical evidence, but due to the sheer number of times I have seen spark in the SerializationUtils.clone method in stack traces I've taken I figured it could use some love.

This functionality was implemented to fix a bug where we were accidentally modifying the properties man used by other threads. That solution was to use SerializationUtils.clone, but that is not necessary. I suggest just creating a new Properties object and iterating over the key-value pairs in the original map and adding them one by one.

Issue Links

• links to: GitHub Pull Request #25787
• links to: GitHub Pull Request #26666