[SPARK-27346] Loosen the newline assert condition on 'examples' field in ExpressionInfo

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.4.1, 3.0.0
• Fix Version/s: 2.4.2, 3.0.0
• Component/s: SQL
• Assignee: Hyukjin Kwon
• Reporter: Hyukjin Kwon
• Created: 02/Apr/19 09:33
• Updated: 12/Dec/22 18:11
• Resolved: 02/Apr/19 23:28

Description

I haven't tested by myself on Windows and I am not 100% sure if this is going to cause an actual problem.

The codes here:

        assert examples.isEmpty() || examples.startsWith(System.lineSeparator() + "    Examples:");

Given my speculation, if Spark is built in Linux, and it's executed on Windows, it looks possible to throw an exception because encoded newline in the binary is \n but System.lineSeparator returns \r\n.

I haven't tested it by myself but I think it's better to loosen the condition and forget about this problem.

Issue Links

• links to: GitHub Pull Request #24274