[SPARK-2730] When retrieving a value from a Map, GetItem evaluates key twice

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.3, 1.1.0
• Component/s: SQL
• Assignee: Yin Huai
• Reporter: Yin Huai
• Created: 29/Jul/14 16:51
• Updated: 29/Jul/14 19:24
• Resolved: 29/Jul/14 19:24

Description

override def eval(input: Row): Any = {
    val value = child.eval(input)
    if (value == null) {
      null
    } else {
      val key = ordinal.eval(input)
      if (key == null) {
        null
      } else {
        if (child.dataType.isInstanceOf[ArrayType]) {
          // TODO: consider using Array[_] for ArrayType child to avoid
          // boxing of primitives
          val baseValue = value.asInstanceOf[Seq[_]]
          val o = key.asInstanceOf[Int]
          if (o >= baseValue.size || o < 0) {
            null
          } else {
            baseValue(o)
          }
        } else {
          val baseValue = value.asInstanceOf[Map[Any, _]]
          val key = ordinal.eval(input) // We evaluate the key again at here
          baseValue.get(key).orNull
        }
      }
    }
  }

Issue Links

• links to: [Github] Pull Request #1637 (yhuai)