[SPARK-23769] Remove unnecessary scalastyle check disabling

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.3.1, 2.4.0
• Component/s: Spark Core
• Assignee: Riaas Mokiem
• Reporter: Riaas Mokiem
• Created: 22/Mar/18 11:48
• Updated: 12/Dec/22 18:10
• Resolved: 23/Mar/18 12:05

Description

In `org/apache/spark/util/CompletionIterator.scala` the Scalastyle checker is disabled for 1 line of code. However, this line of code doesn't seem to violate any of the currently active rules for Scalastyle. So the Scalastyle checker doesn't need to be disabled there.

I've tested this by removing the comments that disable the checker and running the checker with `build/mv scalastyle:check`. With the comments removed (so with the checker active for that line) the build still succeeds and no violations are shown in `core/target/scalastyle-output.xml`. I'll create a pull request to remove the comments that disable the checker.

Issue Links

• links to: [Github] Pull Request #20880 (arucard21)