Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-23769

Remove unnecessary scalastyle check disabling

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.3.1, 2.4.0
    • Component/s: Spark Core
    • Labels:
      None

      Description

      In `org/apache/spark/util/CompletionIterator.scala` the Scalastyle checker is disabled for 1 line of code. However, this line of code doesn't seem to violate any of the currently active rules for Scalastyle. So the Scalastyle checker doesn't need to be disabled there.

      I've tested this by removing the comments that disable the checker and running the checker with `build/mv scalastyle:check`. With the comments removed (so with the checker active for that line) the build still succeeds and no violations are shown in `core/target/scalastyle-output.xml`. I'll create a pull request to remove the comments that disable the checker.

        Attachments

          Activity

            People

            • Assignee:
              arucard Riaas Mokiem
              Reporter:
              arucard Riaas Mokiem
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: