[SPARK-2342] Evaluation helper's output type doesn't conform to input type

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.1, 1.1.0
• Component/s: SQL
• Labels: easyfix
• Assignee: Unassigned
• Reporter: Yijie Shen
• Created: 02/Jul/14 08:14
• Updated: 03/Jul/14 20:29
• Resolved: 03/Jul/14 20:29

Description

In sql/catalyst/org/apache/spark/sql/catalyst/expressions.scala

protected final def n2 ( i: Row, e1: Expression, e2: Expression, f: ((Numeric[Any], Any, Any) => Any)): Any  

is intended to do computations for Numeric add/Minus/Multipy.
Just as the comment suggest :

Those expressions are supposed to be in the same data type, and also the return type.

But in code, function f was casted to function signature:

(Numeric[n.JvmType], n.JvmType, n.JvmType) => Int

I thought it as a typo and the correct should be:

(Numeric[n.JvmType], n.JvmType, n.JvmType) => n.JvmType