[SPARK-22607] Set large stack size consistently for tests to avoid StackOverflowError

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.2.2, 2.3.0
• Component/s: Build, Tests
• Target Version/s: 2.2.1
• Assignee: Sean R. Owen
• Reporter: Sean R. Owen
• Created: 25/Nov/17 18:24
• Updated: 26/Nov/17 13:46
• Resolved: 26/Nov/17 13:46

Description

I was seeing this error while testing the 2.2.1 RC:

OrderingSuite:
...
- GenerateOrdering with ShortType
*** RUN ABORTED ***
java.lang.StackOverflowError: 
at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:370) 
at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:541) 
at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:541) 
at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:541) 
at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:541) 
at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:541) 
at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:541) 
at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:541)
...

This doesn't seem to happen on Jenkins, for whatever reason. It seems like we set JVM flags for tests inconsistently, and in particular, only set a 4MB stack size for surefire, not scalatest-maven-plugin. Adding -Xss4m made the test pass for me.

We can also make sure that all of these pass -ea consistently.

Issue Links

• links to: [Github] Pull Request #19820 (srowen)