Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-22281

Handle R method breaking signature changes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.1, 2.3.0
    • Fix Version/s: 2.2.1, 2.3.0
    • Component/s: SparkR
    • Labels:
      None

      Description

      cAs discussed here
      http://apache-spark-developers-list.1001551.n3.nabble.com/VOTE-Spark-2-1-2-RC2-tt22540.html#a22555

      this WARNING on R-devel

      • checking for code/documentation mismatches ... WARNING
        Codoc mismatches from documentation object 'attach':
        attach
        Code: function(what, pos = 2L, name = deparse(substitute(what),
        backtick = FALSE), warn.conflicts = TRUE)
        Docs: function(what, pos = 2L, name = deparse(substitute(what)),
        warn.conflicts = TRUE)
        Mismatches in argument default values:
        Name: 'name' Code: deparse(substitute(what), backtick = FALSE) Docs: deparse(substitute(what))

      Codoc mismatches from documentation object 'glm':
      glm
      Code: function(formula, family = gaussian, data, weights, subset,
      na.action, start = NULL, etastart, mustart, offset,
      control = list(...), model = TRUE, method = "glm.fit",
      x = FALSE, y = TRUE, singular.ok = TRUE, contrasts =
      NULL, ...)
      Docs: function(formula, family = gaussian, data, weights, subset,
      na.action, start = NULL, etastart, mustart, offset,
      control = list(...), model = TRUE, method = "glm.fit",
      x = FALSE, y = TRUE, contrasts = NULL, ...)
      Argument names in code not in docs:
      singular.ok
      Mismatches in argument names:
      Position: 16 Code: singular.ok Docs: contrasts
      Position: 17 Code: contrasts Docs: ...

      Checked the latest release R 3.4.1 and the signature change wasn't there. This likely indicated an upcoming change in the next R release that could incur this new warning when we attempt to publish the package.

      Not sure what we can do now since we work with multiple versions of R and they will have different signatures then.

        Attachments

          Activity

            People

            • Assignee:
              felixcheung Felix Cheung
              Reporter:
              felixcheung Felix Cheung
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: