[SPARK-21223] Thread-safety issue in FsHistoryProvider

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.1
• Fix Version/s: 2.3.0
• Component/s: Spark Core
• Assignee: zenglinxi
• Reporter: zenglinxi
• Created: 27/Jun/17 07:24
• Updated: 30/Jun/17 18:29
• Resolved: 30/Jun/17 18:28

Description

Currently, Spark HistoryServer use a HashMap named fileToAppInfo in class FsHistoryProvider to store the map of eventlog path and attemptInfo.
When use ThreadPool to Replay the log files in the list and merge the list of old applications with new ones, multi thread may update fileToAppInfo at the same time, which may cause Thread-safety issues.

for (file <- logInfos) {
       tasks += replayExecutor.submit(new Runnable {
        override def run(): Unit = mergeApplicationListing(file)
     })
 }

Issue Links

• relates to: SPARK-21078 JobHistory applications synchronized is invalid
• links to: [Github] Pull Request #18430 (zenglinxi0615)