[SPARK-20798] GenerateUnsafeProjection should check if value is null before calling the getter

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.1.2, 2.2.0
• Component/s: SQL
• Assignee: Ala Luszczak
• Reporter: Ala Luszczak
• Created: 18/May/17 12:11
• Updated: 19/May/17 11:20
• Resolved: 19/May/17 11:20

Description

GenerateUnsafeProjection.writeStructToBuffer() does not honor the assumption that one should first make sure the value is not null before calling the getter. This can lead to errors.

An example of generated code:

/* 059 */         final UTF8String fieldName = value.getUTF8String(0);
/* 060 */         if (value.isNullAt(0)) {
/* 061 */           rowWriter1.setNullAt(0);
/* 062 */         } else {
/* 063 */           rowWriter1.write(0, fieldName);
/* 064 */         }

Issue Links

• links to: [Github] Pull Request #18030 (ala)