Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-20253

Remove unnecessary nullchecks of a return value from Spark runtime routines in generated Java code

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersStop watchingWatchersCreate sub-taskConvert to sub-taskLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.2.0
    • 2.2.0
    • SQL
    • None

    Description

      While we know several Spark runtime routines never return null (e.g. UnsafeArrayData.toDoubleArray(), the generated code by Catalyst always checks whether the return value is null or not.
      It is good to remove this nullcheck for reducing Java bytecode size and reducing the native code size.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            kiszk Kazuaki Ishizaki Assign to me
            kiszk Kazuaki Ishizaki
            Votes:
            0 Vote for this issue
            Watchers:
            3 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment