[SPARK-19899] FPGrowth input column naming

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.2.0
• Component/s: ML
• Target Version/s: 2.2.0
• Assignee: Maciej Szymkiewicz
• Reporter: Maciej Szymkiewicz
• Shepherd: Joseph K. Bradley
• Created: 10/Mar/17 12:31
• Updated: 20/Mar/17 17:58
• Resolved: 20/Mar/17 17:58

Description

Current implementation extends HasFeaturesCol. Personally I find it rather unfortunate. Up to this moment we used consistent conventions - if we mix-in HasFeaturesCol the featuresCol should be VectorUDT.

Using the same Param for an array<T> (and possibly for array<arrray<T>> once PrefixSpan is ported to ml) will be confusing for the users.

I would like to suggest adding new trait (let's say HasTransactionsCol) to clearly indicate that the input type differs for the other Estiamtors.

Issue Links

• blocks: SPARK-19281 spark.ml Python API for FPGrowth
• blocks: SPARK-19825 spark.ml R API for FPGrowth
• is related to: SPARK-14503 spark.ml Scala API for FPGrowth
• is related to: SPARK-19825 spark.ml R API for FPGrowth
• is related to: SPARK-14501 spark.ml parity for fpm - frequent items
• links to: [SPARK-19899][ML] Replace featuresCol with itemsCol in ml.fpm.FPGrowth