[SPARK-19617] Fix the race condition when starting and stopping a query quickly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.2, 2.1.0
• Fix Version/s: 2.1.1, 2.2.0
• Component/s: Structured Streaming
• Assignee: Shixiong Zhu
• Reporter: Shixiong Zhu
• Created: 16/Feb/17 00:58
• Updated: 28/Feb/17 18:56
• Resolved: 22/Feb/17 04:16

Description

The streaming thread in StreamExecution uses the following ways to check if it should exit:

• Catch an InterruptException.
• `StreamExecution.state` is TERMINATED.

when starting and stopping a query quickly, the above two checks may both fail.

• Hit HADOOP-14084 and swallow InterruptException
• StreamExecution.stop is called before `state` becomes `ACTIVE`. Then runBatches changes the state from `TERMINATED` to `ACTIVE`.

If the above cases both happen, the query will hang forever.

Issue Links

• is related to: HADOOP-14084 Shell.joinThread swallows InterruptedException
• relates to: SPARK-19718 Fix flaky test: org.apache.spark.sql.kafka010.KafkaSourceStressForDontFailOnDataLossSuite: stress test for failOnDataLoss=false
• links to: [Github] Pull Request #16947 (zsxwing)
• links to: [Github] Pull Request #16979 (zsxwing)
• links to: [Github] Pull Request #16980 (gf53520)