[SPARK-19450] Replace askWithRetry with askSync.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.2.0
• Component/s: Spark Core
• Assignee: Jin Xing
• Reporter: Jin Xing
• Created: 03/Feb/17 17:20
• Updated: 31/Dec/20 19:58
• Resolved: 19/Feb/17 12:34

Description

askSync is already added in RpcEndpointRef (see SPARK-19347 and https://github.com/apache/spark/pull/16690#issuecomment-276850068) and askWithRetry is marked as deprecated.
As mentioned SPARK-18113(https://github.com/apache/spark/pull/16503#event-927953218):

askWithRetry is basically an unneeded API, and a leftover from the akka days that doesn't make sense anymore. It's prone to cause deadlocks (exactly because it's blocking), it imposes restrictions on the caller (e.g. idempotency) and other things that people generally don't pay that much attention to when using it.

Since askWithRetry is just used inside spark and not in user logic. It might make sense to replace all of them with askSync.

Issue Links

• links to: [Github] Pull Request #16790 (jinxing64)