Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-19181

SparkListenerSuite.local metrics fails when average executorDeserializeTime is too short.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.0
    • Fix Version/s: 2.3.1, 2.4.0
    • Component/s: Tests
    • Labels:
      None

      Description

      https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala#L249

      The "local metrics" test asserts that tasks should take more than 1ms on average to complete, even though a code comment notes that this is a small test and tasks may finish faster. I've been seeing some "failures" here on fast systems that finish these tasks quite quickly.

      There are a few ways forward here:
      1. Disable this test.
      2. Relax this check.
      3. Implement sub-millisecond granularity for task times throughout Spark.
      4. (Imran Rashid's suggestion) Add buffer time by, say, having the task reference a partition that implements a custom Externalizable.readExternal, which always waits 1ms before returning.

        Attachments

          Activity

            People

            • Assignee:
              attilapiros Attila Zsolt Piros
              Reporter:
              jsoltren Jose Soltren
              Shepherd:
              Imran Rashid
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: