Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-18196

Optimise CompactBuffer implementation

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.6.2, 2.0.1
    • Fix Version/s: None
    • Component/s: Spark Core
    • Labels:
      None

      Description

      This change slightly increases the class footprint (8 bytes on IBM Java, 12 bytes on OpenJDK and Oracle's) but we've observed a 4% performance on PageRank using HiBench large with this change, so a worthy trade-off IMO

      This results in a shorter path length for the JIT as a result of less if else statements

      Config used on HiBench

      spark.executor.memory 25G
      spark.driver.memory 4G
      spark.serializer org.apache.spark.serializer.KryoSerializer

        Issue Links

          Activity

          Hide
          apachespark Apache Spark added a comment -

          User 'a-roberts' has created a pull request for this issue:
          https://github.com/apache/spark/pull/15713

          Show
          apachespark Apache Spark added a comment - User 'a-roberts' has created a pull request for this issue: https://github.com/apache/spark/pull/15713
          Hide
          srowen Sean Owen added a comment -

          For now looks like a "wontfix" as it doesn't result in a speedup.

          Show
          srowen Sean Owen added a comment - For now looks like a "wontfix" as it doesn't result in a speedup.

            People

            • Assignee:
              Unassigned
              Reporter:
              aroberts Adam Roberts
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development