[SPARK-17783] Hide Credentials in CREATE and DESC FORMATTED/EXTENDED a PERSISTENT/TEMP Table for JDBC

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.1, 2.1.0
• Fix Version/s: 2.0.3, 2.1.0
• Component/s: SQL
• Assignee: Xiao Li
• Reporter: Xiao Li
• Created: 05/Oct/16 04:48
• Updated: 07/Aug/19 10:39
• Resolved: 28/Nov/16 15:07

Description

We should never expose the Credentials in the EXPLAIN and DESC FORMATTED/EXTENDED command. However, below commands exposed the credentials.

CREATE TABLE tab1 USING org.apache.spark.sql.jdbc

== Physical Plan ==
ExecutedCommand
   +- CreateDataSourceTableCommand CatalogTable(
	Table: `tab1`
	Created: Tue Oct 04 21:39:44 PDT 2016
	Last Access: Wed Dec 31 15:59:59 PST 1969
	Type: MANAGED
	Provider: org.apache.spark.sql.jdbc
	Storage(Properties: [url=jdbc:h2:mem:testdb0;user=testUser;password=testPass, dbtable=TEST.PEOPLE, user=testUser, password=testPass])), false

DESC FORMATTED tab1

...
|# Storage Information       |                                                                  |       |
|Compressed:                 |No                                                                |       |
|Storage Desc Parameters:    |                                                                  |       |
|  path                      |file:/Users/xiaoli/IdeaProjects/sparkDelivery/spark-warehouse/tab1|       |
|  url                       |jdbc:h2:mem:testdb0;user=testUser;password=testPass               |       |
|  dbtable                   |TEST.PEOPLE                                                       |       |
|  user                      |testUser                                                          |       |
|  password                  |testPass                                                          |       |
+----------------------------+------------------------------------------------------------------+-------+

DESC EXTENDED tab1

...
	Storage(Properties: [path=file:/Users/xiaoli/IdeaProjects/sparkDelivery/spark-warehouse/tab1, url=jdbc:h2:mem:testdb0;user=testUser;password=testPass, dbtable=TEST.PEOPLE, user=testUser, password=testPass]))|       |

CREATE TEMP VIEW tab1 USING org.apache.spark.sql.jdbc

== Physical Plan ==
ExecutedCommand
   +- CreateTempViewUsing `tab1`, false, org.apache.spark.sql.jdbc, Map(url -> jdbc:h2:mem:testdb0;user=testUser;password=testPass, dbtable -> TEST.PEOPLE, user -> testUser, password -> testPass)

Issue Links

• relates to: SPARK-28642 Hide credentials in show create table
• links to: [Github] Pull Request #15358 (gatorsmile)
• links to: [Github] Pull Request #16047 (gatorsmile)