Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-13135

Don't print expressions recursively in generated code

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: SQL
    • Labels:
      None

      Description

      Our code generation currently prints expressions recursively. For example, for expression "(1 + 1) + 1)", we would print the following:

      "(1 + 1) + 1)"
      "(1 + 1)"
      "1"
      "1"

      We should just print the project list once.

        Issue Links

          Activity

          Hide
          apachespark Apache Spark added a comment -

          User 'rxin' has created a pull request for this issue:
          https://github.com/apache/spark/pull/11019

          Show
          apachespark Apache Spark added a comment - User 'rxin' has created a pull request for this issue: https://github.com/apache/spark/pull/11019
          Hide
          davies Davies Liu added a comment -

          That PR is not merged.

          Show
          davies Davies Liu added a comment - That PR is not merged.
          Hide
          rxin Reynold Xin added a comment -

          cc Dongjoon Hyun do you have time to take my pr and bring it up to date?

          Show
          rxin Reynold Xin added a comment - cc Dongjoon Hyun do you have time to take my pr and bring it up to date?
          Hide
          dongjoon Dongjoon Hyun added a comment -

          Sure! I'll take a look and bring it up-to-date this afternoon.

          Show
          dongjoon Dongjoon Hyun added a comment - Sure! I'll take a look and bring it up-to-date this afternoon.
          Hide
          apachespark Apache Spark added a comment -

          User 'dongjoon-hyun' has created a pull request for this issue:
          https://github.com/apache/spark/pull/13192

          Show
          apachespark Apache Spark added a comment - User 'dongjoon-hyun' has created a pull request for this issue: https://github.com/apache/spark/pull/13192

            People

            • Assignee:
              dongjoon Dongjoon Hyun
              Reporter:
              rxin Reynold Xin
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development