XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: ML
    • Labels:
      None
    • Target Version/s:

      Description

      This is for a few updates to the original PR for basic ML import/export in SPARK-11217.

      • The original PR diverges from the design doc in that it does not include the Spark version or a model format version. We should include the Spark version in the metadata. If we do that, then we don't really need a model format version.
      • Proposal: DefaultParamsWriter includes two separable pieces of logic in save(): (a) handling overwriting and (b) saving Params. I want to separate these by putting (a) in a save() method in Writer which calls an abstract saveImpl, and (b) in the saveImpl implementation in DefaultParamsWriter. This is described below:
      abstract class Writer {
        def save(path: String) = {
          // handle overwrite
          saveImpl(path)
        }
        def saveImpl(path: String)   // abstract
      }
      
      class DefaultParamsWriter extends Writer {
        def saveImpl(path: String) = {
          // save Params
        }
      }
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                josephkb Joseph K. Bradley
                Reporter:
                josephkb Joseph K. Bradley
                Shepherd:
                Xiangrui Meng
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: