Details
Minor Description
Implementing tallSkinnyQR in SPARK-9656 uncovered a bug with our PySpark RowMatrix constructor. As discussed on the dev list here, there appears to be an issue with type erasure with RDDs coming from Java, and by extension from PySpark. Although we are attempting to construct a RowMatrix from an RDD[Vector] in PythonMLlibAPI, the Vector type is erased, resulting in an RDD[Object]. Thus, when calling Scala's tallSkinnyQR from PySpark, we get a Java ClassCastException in which an Object cannot be cast to a Spark Vector. As noted in the aforementioned dev list thread, this issue was also encountered with DecisionTrees, and the fix involved an explicit retag of the RDD with a Vector type. Thus, this PR will apply that fix to the createRowMatrix helper function in PythonMLlibAPI. IndexedRowMatrix and CoordinateMatrix do not appear to have this issue likely due to their related helper functions in PythonMLlibAPI creating the RDDs explicitly from DataFrames with pattern matching, thus preserving the types.
The following reproduces this issue on the latest Git head, 1.5.1, and 1.5.0:
from pyspark.mllib.linalg.distributed import RowMatrix rows = sc.parallelize([[3, -6], [4, -8], [0, 1]]) mat = RowMatrix(rows) mat._java_matrix_wrapper.call("tallSkinnyQR", True)
Should result in the following exception:
java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to [Lorg.apache.spark.mllib.linalg.Vector;
Attachments
Issue Links
- blocks
-
SPARK-9656 Add missing methods to linalg.distributed
-
- Resolved
-
- relates to
-
SPARK-16372 Retag RDD to tallSkinnyQR of RowMatrix
-
- Resolved
-
- links to
