Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-6813 SparkR style guide
  3. SPARK-11492

Ignore commented code warnings in SparkR

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Duplicate
    • None
    • 1.5.0
    • SparkR
    • None

    Description

      cc Shivaram Venkataraman

      We have many commented code warnings under the lastest lintr. Should we turnn off commented_code_linter rule of lintr?

      # rdd <- lapply(parallelize(sc, 1:10), function(x) list(a=x, b=as.character(x)))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      R/SQLContext.R:176:3: style: Commented code should be removed.
      # df <- toDF(rdd)
        ^~~~~~~~~~~~~~~
      R/SQLContext.R:232:3: style: Commented code should be removed.
      # sc <- sparkR.init()
        ^~~~~~~~~~~~~~~~~~~
      R/SQLContext.R:233:3: style: Commented code should be removed.
      # sqlContext <- sparkRSQL.init(sc)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      R/SQLContext.R:234:3: style: Commented code should be removed.
      # rdd <- texFile(sc, "path/to/json")
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      R/SQLContext.R:235:3: style: Commented code should be removed.
      # df <- jsonRDD(sqlContext, rdd)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            yuu.ishikawa@gmail.com Yu Ishikawa
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment