[SPARK-11352] codegen.GeneratePredicate fails due to unquoted comment

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.1
• Fix Version/s: 1.5.3, 1.6.0
• Component/s: SQL
• Labels: backport-needed
• Target Version/s: 1.5.3, 1.6.0
• Assignee: Yin Huai
• Reporter: Rares Mirica
• Created: 27/Oct/15 16:09
• Updated: 24/Oct/16 04:47
• Resolved: 02/Dec/15 00:26

Description

Somehow the code being generated ends up having comments with comment-terminators unquoted, eg.:

/* ((input[35, StringType] <= text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8) && (text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8 <= input[36, StringType])) */

with emphasis on ... =0.9,*/...

This leads to a org.codehaus.commons.compiler.CompileException

Issue Links

• is duplicated by: SPARK-12451 Regexp functions don't support patterns containing '*/'
• relates to: SPARK-15165 Codegen can break because toCommentSafeString is not actually safe
• links to: [Github] Pull Request #10072 (yhuai)
• links to: [Github] Pull Request #10084 (yhuai)